feat: return modal's close button#2948
Merged
MartinCupela merged 2 commits intomasterfrom Feb 16, 2026
Merged
Conversation
…to --control-play-control-bg
MartinCupela
requested review from
arnautov-anton and
oliverlaz
as code owners
|
Size Change: +63 B (+0.02%) Total Size: 338 kB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
Returning close button is necessary for ModalGallery as there is not clear visual hint how to close the gallery. Clicking on transparent parts of modal inner does not close the gallery even though these parts look like overlay.
🎨 UI Changes
The close button is now of ghost circular variant